fix: invalid compressed file for huge file #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 92.91% 92.94% +0.03%
==========================================
Files 45 45
Lines 2681 2693 +12
==========================================
+ Hits 2491 2503 +12
Misses 190 190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TheCrab13
force-pushed
the
fix/crash-with-large-file/no-ref
branch
from
1bbeb1f
to
1e6b324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported by client, pdbstore is generating incomplete compressed file based on
makecab.exeutility.Reference: https://techcommunity.microsoft.com/t5/windows-server-for-developers/makecab-command-has-limitation-of-2gb-package-size/m-p/1599480